[Webkit-unassigned] [Bug 17130] Stop Windows from eating crashes in timer callbacks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 21:03:30 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=17130


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18839|review?                     |review+
               Flag|                            |




------- Comment #2 from aroben at apple.com  2008-01-31 21:03 PDT -------
(From update of attachment 18839)
 #include "Page.h"
+#if PLATFORM(WIN)
 #include "PluginViewWin.h"
+#endif
 #include "SystemTime.h"
 #include "Widget.h"
 #include <wtf/Assertions.h>
+#if PLATFORM(WX)
+#include <wx/wx.h>
+#endif
 #include <windows.h>

Please put any #ifdef'd headers in their own paragraph after all the
non-#ifdef'd headers. That's the style we use in most files like this.

+
 namespace WebCore {

This extra newline isn't needed.

r=me, even if these issues aren't fixed. It would be nice to fix these before
committing though.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list