[Webkit-unassigned] [Bug 14270] Impossible to close web inspector when docked to webview

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14270


webkit at mattlilek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18795|0                           |1
        is obsolete|                            |
         AssignedTo|webkit-                     |webkit at mattlilek.com
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED




------- Comment #5 from webkit at mattlilek.com  2008-01-31 16:40 PDT -------
Created an attachment (id=18836)
 --> (http://bugs.webkit.org/attachment.cgi?id=18836&action=view)
revised patch

This is a revised patch based on Adam's comments, but I'm not putting it up for
official review.  It's mainly to see whether my Windows code is horribly wrong
or not.

(In reply to comment #3)
> (From update of attachment 18795 [edit])
> +        { "attachedClose", attachedClose, kJSPropertyAttributeNone },
> 
> Maybe "hide" would be a better name for this method?
> 
> I think the Windows code could be better factored to share more code between
> closeWindow and closeAttachedWindow. It also seems strange to have to call
> ShowWindow(SW_HIDE) in closeAttachedWindow() -- won't th window already be
> hidden?
> 

Thats what you'd think, but I'm not 100% sure - I don't really know enough
about Windows' windowing system.  If my revised code is still wrong, I'd love
pointers to figuring out what I'm screwing up.

> Is there any flashing when m_attachOnShow is true? I'd expect to see the
> detached window appear, then disappear given the way the code is written.
> 

Yes, I overlooked that in my initial patch.  It's taken care of in this
revision.

> Any chance we could see some screenshots of the new close button in action?
> 

I'll upload a screenshot of it in a moment. If the general style is okay, I'll
photoshop it to be a - instead of an X.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.