[Webkit-unassigned] [Bug 14270] Impossible to close web inspector when docked to webview

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14270


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18795|review?                     |review-
               Flag|                            |




------- Comment #3 from aroben at apple.com  2008-01-30 12:06 PDT -------
(From update of attachment 18795)
+        { "attachedClose", attachedClose, kJSPropertyAttributeNone },

Maybe "hide" would be a better name for this method?

I think the Windows code could be better factored to share more code between
closeWindow and closeAttachedWindow. It also seems strange to have to call
ShowWindow(SW_HIDE) in closeAttachedWindow() -- won't th window already be
hidden?

Is there any flashing when m_attachOnShow is true? I'd expect to see the
detached window appear, then disappear given the way the code is written.

Any chance we could see some screenshots of the new close button in action?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.