[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16979





------- Comment #25 from bfulgham at gmail.com  2008-01-29 09:16 PDT -------
(In reply to comment #24)
> (From update of attachment 18740 [edit])
> Once you're inside a CG file, there is no need to conditionalize the header
> include (see FrameCGWin.cpp).

Some of these issues are caused by the use of 'svn cp' to generate the initial
"CG" variant files.  The final version of FrameCGWin.cpp does *not* have any
conditionalization around the Core Graphics headers.

> If I'm picking on you about existing code that's somehow showing up as + lines,
> my apologies... I should be picking on aroben or whatever Apple windows hacker
> violated their own published guidelines. :)
> 

Most of the items you mention are from existing code that was copied over from
the 'parent' class; however, it's good to get it right now (it may be a while
before anyone looks at this again).

I'll make these changes and update the patch.



-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.