[Webkit-unassigned] [Bug 16994] SmartReplace.cpp isn't implemented for platforms without CoreFoundation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 29 07:49:05 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16994


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18752|review?                     |review-
               Flag|                            |




------- Comment #5 from darin at apple.com  2008-01-29 07:49 PDT -------
(From update of attachment 18752)
+#ifdef USE(ICU_UNICODE)

That's incorrect. It needs to be:

#if USE(ICU_UNICODE)

And the ICU version should really be in a different file, as the CF version is.

review- because of the ifdef/if issue.


------- Comment #6 from darin at apple.com  2008-01-29 07:49 PDT -------
(From update of attachment 18752)
+#ifdef USE(ICU_UNICODE)

That's incorrect. It needs to be:

#if USE(ICU_UNICODE)

And the ICU version should really be in a different file, as the CF version is.

review- because of the ifdef/if issue.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list