[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 09:16:37 PST 2008


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #18731|review?                     |review-
               Flag|                            |

------- Comment #22 from aroben at apple.com  2008-01-28 09:16 PDT -------
(From update of attachment 18731)
I think it would be nicer to use 'svn cp' when creating the *CGWin.cpp files.
For example:

svn cp FrameWin.cpp FrameCGWin.cpp

That way it'll be easier to track the changes to the methods defined in the
*CGWin.cpp files across the split in history.

The #includes in FrameCairoWin.cpp could probably be reduced quite a bit.

A number of your new methods in the *CairoWin.cpp files throughout this patch
are missing return statements.

+GraphicsContext::GraphicsContext(HDC hdc)
+//    : m_common(createGraphicsContextPrivate())
+//    , m_data(new GraphicsContextPlatformPrivate(CGContextWithHDC(hdc)))
+//    CGContextRelease(m_data->m_cgContext);

We generally don't like to commit commented-out code.

I think this is very close to being ready to go in to Subversion.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list