[Webkit-unassigned] [Bug 17017] Remove KJS::UChar

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17017





------- Comment #10 from darin at apple.com  2008-01-26 16:01 PDT -------
(In reply to comment #8)
> The sign-extend issue calls the whole patch into question!  Since the goal was
> not to make it easier to hack on WebKit (less confusion) rather than harder
> (dangerous to convert from char to UChar)!

Nah, it's not all that important. It's not super-helpful to have char convert
to UChar by 0-filling any more than by sign extending. It's just a subtle
change at the switchover time. In the long run, it's find to have the single
integral type.

The safest way to do things would be to change KJS::UChar to remove the special
char-conversion feature, then do the switchover in a separate step.

I thought of one other difference between UChar and KJS::UChar. The latter
default constructs to 0 even in cases where the raw type constructs
uninitialized. These are the only things to worry about when switching over.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.