[Webkit-unassigned] [Bug 16994] SmartReplace.cpp isn't implemented for platforms without CoreFoundation

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16994


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18638|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-01-26 08:25 PDT -------
(From update of attachment 18638)
Code looks fine, but it's not platform-independent since it uses ICU; not all
ports of WebCore have ICU, and it's not acceptable to just have ICU code
without any ifdefs. It should go into a file named SmartReplaceICU.cpp and be
properly ifdef'd. Otherwise, fine.

+        // Nice to have, added in ICU 3.8.
+        //uset_freeze(smartSet);

This can be ifdef'd based on the ICU headers. It would be better to either
include it for real or not. We don't normally include commented out code.

The if is "#if USE (ICU_UNICODE)" I believe. You should look for an example.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.