[Webkit-unassigned] [Bug 17018] Incorrect code generated from Function.toString for get/setters in object literals

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17018


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver at apple.com
             Status|NEW                         |ASSIGNED




------- Comment #1 from oliver at apple.com  2008-01-26 03:58 PDT -------
Fix appears to be
diff --git a/JavaScriptCore/kjs/nodes2string.cpp
b/JavaScriptCore/kjs/nodes2string.cpp
index 0432b7f..79a0675 100644
--- a/JavaScriptCore/kjs/nodes2string.cpp
+++ b/JavaScriptCore/kjs/nodes2string.cpp
@@ -370,11 +370,11 @@ void PropertyNode::streamTo(SourceStream& s) const
         case Setter: {
             const FuncExprNode* func = static_cast<const
FuncExprNode*>(assign.get());
             if (type == Getter)
-                s << "get \""; 
+                s << "get "; 
             else
-                s << "set \"";
+                s << "set ";
             s << escapeStringForPrettyPrinting(name().ustring())
-                << "\"(" << func->param << ')' << func->body;
+                << "(" << func->param << ')' << func->body;
             break;
         }
     }


But I can't see why they were ever escaped strings -- is there a case i am
missing where 'set "foo"(x)' would be valid?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.