[Webkit-unassigned] [Bug 16979] Patch to conditionalize some CG/Cairo support in win32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 23 08:39:53 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16979





------- Comment #5 from aroben at apple.com  2008-01-23 08:39 PDT -------
(From update of attachment 18613)
I don't think it's so great to have all these #ifdefs within each "Win" file. I
think we're taking "Win" too literally here -- it doesn't (and shouldn't) mean
"any port building on Windows" (for example, Qt/win doesn't use these files).
Right now "Win" means "the Windows port which depends on CG, CF, CFNetwork,
etc.". Clearly "Win" is not a great name for this. We should try to come up
with a better name for the current port and a good name for the port you're
starting to create. Then we can separate the implementations into separate
files for each port, instead of tossing all these #ifdefs in.

I've CCed Darin because I know he's been thinking about this naming issue as
well.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list