[Webkit-unassigned] [Bug 16925] New: How to fix VectorBuffer's FIXME

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16925

           Summary: How to fix VectorBuffer's FIXME
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: maruel at gmail.com


To remove the FIXME for VectorBuffer<>::m_inlineBuffer at line 381, you should
define the alignment, which is a compiler-specific attribute. That would help
for Vector<double> and would be needed to use with SSE primitives.

For GCC, I think that would be:
  char __attribute__((aligned(__alignof__(T))))
m_inlineBuffer[m_inlineBufferSize];

For MSVC, I think that would be:
  char __declspec(align(__alignof(T))) m_inlineBuffer[m_inlineBufferSize];

For sure, a macro would need to be defined to not directly clutter the code.
Since I don't know where to put the necessary macros, I'll let more
experimented folks figure that out.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.