[Webkit-unassigned] [Bug 14811] [gtk] [request] add a webkit_gtk_page_go_to_history_item function

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14811





------- Comment #15 from xan.lopez at gmail.com  2008-01-16 15:14 PDT -------
(In reply to comment #14)
> (From update of attachment 18468 [edit])
> >+static void webkit_web_back_forward_list_dispose(GObject* object)
> >+{
> >+    WebKitWebBackForwardList* webbflist = WEBKIT_WEB_BACK_FORWARD_LIST(object);
> >+
> >+    delete webbflist->priv->backForwardList;
> >+}
> 
> Personally I find 'webbflist' unreadable.
> 
> Besides you shouldn't use the private pointer directly.
> 
> >+static void webkit_web_back_forward_list_init(WebKitWebBackForwardList* object)
> >+{
> >+    object->priv = WEBKIT_WEB_BACK_FORWARD_LIST_GET_PRIVATE(object);
> >+}
> 
> This line is superfluous. It doesn't do anything.
> 

That line sets the priv pointer in the struct to the object private data, so it
does something. And accessing directly the priv pointer from within the object
implementation is an extremely widely used technique/optimization in the GTK+
world.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.