[Webkit-unassigned] [Bug 16871] Crash when loading apple.com/startpage

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16871





------- Comment #7 from cwzwarich at uwaterloo.ca  2008-01-15 14:27 PDT -------
Adam tried out my latest patch (attachment 18461) for bug 16868, and he said
that it fixes the crash for him. Commenting out the lines

        if (exec->m_savedExec != exec->m_callingExec && exec->m_savedExec)
            exec->m_savedExec->mark();

makes it crash, and commenting out the lines

        if (exec->m_activation && exec->m_activation->isOnStack())
            exec->m_activation->markChildren();

doesn't seem make it crash after quite a number of reloads. Is that added bit
actually necessary now that we are checking savedExec? The patch adding the
m_activation marking made the crash occur less frequently, so it must be
possible for m_activation to not be in the scope chain of an ExecState in the
callingExec chain, but will any such ActivationImp also be in the scope chain
of an ExecState in the savedExec chain?

We should really find an explicit example or code path where the m_activation
marking is necessary.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.