[Webkit-unassigned] [Bug 16868] Gmail crash

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16868





------- Comment #12 from cwzwarich at uwaterloo.ca  2008-01-15 07:59 PDT -------
(In reply to comment #10)
> (From update of attachment 18453 [edit])
> +    if (m_savedExec && m_savedExec != m_callingExec)
> +        m_savedExec->mark();
> 
> The ExecState::mark function marks the scope chains of all the execs in the
> callingExec chain in an iterative way rather than a recursive way. But this new
> savedExec code uses recursion instead.

That's what I was referring to changing when I said we should go down the
callingExec and savedExec chains in parallel. I'll upload a new patch soon that
does that.

> Also, the code to mark the activation is only done on the top ExecState, which
> seems wrong. The m_callingExec loop should either use recursion too (not my
> favorite idea) or we should move the marking of the activation inside that
> loop.

I was going to ask you today if there was any reason you didn't do that in your
patch that added the marking of the activation, but I guess not, so I'll bring
it into the loop.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.