[Webkit-unassigned] [Bug 15195] KJSProxy::m_handlerLineno is not reset between page loads in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 23:38:25 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #18431|review?                     |review+
               Flag|                            |

------- Comment #5 from darin at apple.com  2008-01-14 23:38 PDT -------
(From update of attachment 18431)
Here are some things I notice:

    1) XML doesn't set the line number at all while parsing.

    2) The functions to create event handlers should ask the document's
tokenizer what the current line number is, perhaps with a special function that
is specifically designed for event handlers, rather than storing a line number
inside the KJSProxy object, which seems upside down and backwards to me.

    3) Setting the line number back to 0 is OK, but really doesn't help all
that much.

r=me because there's little harm here. But I don't really like the idea of the
comment in KJSProxy::clear() mentioning FrameLoader::clear().

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list