[Webkit-unassigned] [Bug 16798] <button> does not have type=submit (Acid3 bug)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16798


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18433|review?                     |review-
               Flag|                            |




------- Comment #5 from darin at apple.com  2008-01-14 10:58 PDT -------
(From update of attachment 18433)
+void HTMLButtonElement::attributeChanged(Attribute* attr, bool preserveDecls)
+{
+    if (attr->name() == typeAttr && !attr->value())
+        m_type = SUBMIT;
+    HTMLGenericFormElement::attributeChanged(attr, preserveDecls);
+}

We should not add this override. Instead the code for this should just go into
parseMappedAttribute. It should just be rewritten so it sets m_type to SUBMIT
any time the value is neither RESET nor BUTTON.

I'd like to confirm that HTMLButtonElement.type really returns a different
value than getAttribute("type") in the other browsers. Accordingly, the test
case should check both type and getAttribute("type").

+debug('<span>Start test 1</span>');

I don't think these are great. We normally don't include markup in the debug
statements, and I think it's better not to. And I don't think it adds much to
the output to just number tests here. Maybe if the messages said things like
"removing type attribute" it would be better.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.