[Webkit-unassigned] [Bug 16869] run-webkit-tests should have a --random switch to run tests in random order
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 14 10:03:47 PST 2008
http://bugs.webkit.org/show_bug.cgi?id=16869
------- Comment #3 from freyther at handhelds.org 2008-01-14 10:03 PDT -------
(In reply to comment #2)
> (From update of attachment 18439 [edit])
> r=me
>
> + 'random' => sub { $randomizeTests = 1; },
>
> Why not just => \$randomizeTests? Is there a reason for this one option to be
> different than the others? Also, could you preserve the alphabetical order by
> putting this before "root"?
>
> +if ($randomizeTests == 1) {
> + @tests = shuffle(@tests);
> +}
>
> I'd write in more-idiomatic perl as:
>
> @tests = shuffle(@tests) if $randomizeTests;
>
I have no perl skills at all. Will post a revised patch.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list