[Webkit-unassigned] [Bug 16844] RenderText::addLineBoxRects erroneously includes last char for boundingBox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 13 11:30:14 PST 2008


------- Comment #11 from darin at apple.com  2008-01-13 11:30 PDT -------
(From update of attachment 18397)
Why are we taking the comment out in the second half of the patch? The comment
looks correct.

Also, there's no ChangeLog here and no test case! So why is this review+?

I also think that the terminology "points at" is confusing for an integer. I
would not have used that terminology in comments. Instead I'd say "is the index
of the last character, not the index past it" or something like that.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list