[Webkit-unassigned] [Bug 16850] autotools derivedsources.make, proper shared lib, etc..

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16850





------- Comment #7 from alp at atoker.com  2008-01-12 22:41 PDT -------
(From update of attachment 18411)

> 
> # DOCTYPE strings
> 
>-DocTypeStrings.cpp : html/DocTypeStrings.gperf
>-	gperf -CEot -L ANSI-C -k "*" -N findDoctypeEntry -F ,PubIDInfo::eAlmostStandards,PubIDInfo::eAlmostStandards $< > $@
>+DocTypeStrings.cpp : $(WebCore)/html/DocTypeStrings.gperf
>+	$(GPERF) -CEot -L ANSI-C -k "*" -N findDoctypeEntry -F ,PubIDInfo::eAlmostStandards,PubIDInfo::eAlmostStandards \
>+	$(WebCore)/html/DocTypeStrings.gperf > $@

Why not just:
DocTypeStrings.cpp : $(WebCore)/html/DocTypeStrings.gperf
        $(GPERF) -CEot -L ANSI-C -k "*" -N findDoctypeEntry -F
,PubIDInfo::eAlmostStandards,PubIDInfo::eAlmostStandards $< > $@

> 
> # HTML entity names
> 
>-HTMLEntityNames.c : html/HTMLEntityNames.gperf
>-	gperf -a -L ANSI-C -C -G -c -o -t -k '*' -N findEntity -D -s 2 $< > $@
>+HTMLEntityNames.c : $(WebCore)/html/HTMLEntityNames.gperf
>+	$(GPERF) -a -L ANSI-C -C -G -c -o -t -k '*' -N findEntity -D -s 2 \
>+	$(WebCore)/html/HTMLEntityNames.gperf > $@

Ditto.

> 
> # color names
> 
>-ColorData.c : platform/ColorData.gperf
>-	gperf -CDEot -L ANSI-C -k '*' -N findColor -D -s 2 $< > $@
>+ColorData.c : $(WebCore)/platform/ColorData.gperf
>+	$(GPERF) -CDEot -L ANSI-C -k '*' -N findColor -D -s 2 \
>+	$(WebCore)/platform/ColorData.gperf > $@

Ditto.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.