[Webkit-unassigned] [Bug 14959] No back forward entry added for pages created in javascript

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 21:42:42 PST 2008


------- Comment #13 from eric at webkit.org  2008-01-10 21:42 PDT -------
(From update of attachment 18369)
Looks great Matt.  I'll leave this for Darin to review for real though.

I should note, there are two single line ifs which differ from the style

} else {
 120         mimeType = "text/html";
 121     }

9     if (m_textWrittenByScript) {
 1590         m_textWrittenByScript->append(reinterpret_cast<const
 1591                                       text.length() * sizeof(UChar));
 1592     }

Otherwise the patch as a whole looks sane.  I'll leave darin to do the final

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list