[Webkit-unassigned] [Bug 16029] JavaScriptCore.h is not suitable for platforms other than Mac OS X

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16029





------- Comment #17 from darin at apple.com  2008-01-07 12:40 PDT -------
(In reply to comment #16)
> I'd have preferred to remove JSStringRefCF.h from JavaScriptCore.h and instead
> require applications to include JSStringRefCF.h, JSStringRefBSTR.h or the
> GLib/Qt equivalents as needed.

I know you'd prefer that, but it would be unacceptable for Mac OS X --
JavaScriptCore.h is a public Mac OS X 10.5 header, and we can't change it in an
incompatible way.

> Checking __APPLE__ isn't a great idea since it could limit developers using
> configurations we haven't considered yet (eg. CF on Linux). Better to keep it
> simple and require explicit includes, but if this isn't an option, my patch is
> probably the best compromise.

Yes, agreed. But we need a version of your patch that doesn't break Mac OS X.
Tim took care of that now.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.