[Webkit-unassigned] [Bug 16764] DOMRange doesn't correctly re-size when inserting items (Acid3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 11:23:31 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16764


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18299|review?                     |review+
               Flag|                            |




------- Comment #3 from darin at apple.com  2008-01-06 11:23 PDT -------
(From update of attachment 18299)
Usually a count would be named with a noun. The word "move" is more like a
verb, so "offsetMove" is not a great variable name. Maybe offsetDelta or
endOffsetAdjustment?

+    if (m_startContainer == m_endContainer)
+        m_endOffset += offsetMove;

There's no if statement needed here -- you already ensured that the variable
will be 0 in the case where the two are not equal.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list