[Webkit-unassigned] [Bug 16748] DOMRange.cloneContents does not work (Acid3 bug)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 6 03:04:05 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16748


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18297|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2008-01-06 03:04 PDT -------
(From update of attachment 18297)
There's no need to call fragment.release() if you're not returning the
fragment. A plain old "return 0" will do, and it's more efficient.

Otherwise looks great.

I'll say review+, but really those extra fragment.release() calls should not be
in there.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list