[Webkit-unassigned] [Bug 16749] DOMRange.surroundContents throws wrong exception (Acid3 bug)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16749


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18294|review?                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2008-01-06 01:05 PDT -------
(From update of attachment 18294)
Looks good!

+    } else if (m_startContainer->nodeType() != Node::TEXT_NODE) {

I would just have used isTextNode() here rather than nodeType().

+        if (m_startOffset > 0) {
+            ec = RangeException::BAD_BOUNDARYPOINTS_ERR;
+            return;
+        }

This seems wrong. If m_startOffset is >= m_startContainer->maxCharacterOffset,
I think we're fine here.

review- because of that incorrect case. We need to add a test where the start
container is a comment node and the start offset is the end of the comment
node.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.