[Webkit-unassigned] [Bug 16202] Optimize allocation of ActivationImp objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 5 18:26:16 PST 2008


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
  Attachment #18287|review?                     |
               Flag|                            |
  Attachment #18287|0                           |1
        is obsolete|                            |
  Attachment #18292|                            |review?
               Flag|                            |

------- Comment #13 from cwzwarich at uwaterloo.ca  2008-01-05 18:26 PDT -------
Created an attachment (id=18292)
 --> (http://bugs.webkit.org/attachment.cgi?id=18292&action=view)
Revised proposed patch

(In reply to comment #12)
> (From update of attachment 18287 [edit])
> Obviously the commented out printf()s will need to be removed.

Oops! Took those out.

> Also, the
> indenting is incorrect on things like ActivationImp::init, 4 spaces instead of
> 2.

There might be an indentation problem somewhere, due to the inconsistent
indentation throughout JSC, but I used 2 spaces for ActivationImp::init.

> Single line ifs are two lines:
> if (!switchGlobal) exec->dynamicGlobalObject()->tearOffActivation(exec);


> You should read: http://webkit.org/coding/coding-style.html

I've read it, but I still occasionally make some mistakes. Sorry.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list