[Webkit-unassigned] [Bug 16562] [gtk] Implement WebPolicyDelegate methods
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 14:01:18 PST 2008
http://bugs.webkit.org/show_bug.cgi?id=16562
pierre-luc.beaudoin at collabora.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18040|review? |
Flag| |
Attachment #18040|0 |1
is obsolete| |
Attachment #18276| |review?
Flag| |
------- Comment #2 from pierre-luc.beaudoin at collabora.co.uk 2008-01-04 14:01 PDT -------
Created an attachment (id=18276)
--> (http://bugs.webkit.org/attachment.cgi?id=18276&action=view)
Applied some comments
bdash suggested, with reason, that the mime-type-requested signal name was not
clear, we settled on mime-type-policy-decision-requested. Since
new-window-requested and navigation-requested are clear this way, I won't
change them although we loose on consistency.
I removed the _real_mime_type function to place the default behavior in
FrameLoaderClientGtk::dispatchDecidePolicyForMIMEType instead. This is the
only place the signal is emitted, it makes sens to me.
I added WEBKIT_POLICY_RESPONSE_NULL to allow an handler to return an error or
force the default behavior. Also, when there is no handler to
mime-type-policy-decision-requested, the return value defaults to
WEBKIT_POLICY_RESPONSE_NULL which will trigger the default behavior.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list