[Webkit-unassigned] [Bug 16731] New: unexpected #cdata sections when injecting into XHTML DOM served as application/xhtml+xml

Fri Jan 4 08:37:20 PST 2008

http://bugs.webkit.org/show_bug.cgi?id=16731

           Summary: unexpected #cdata sections when injecting into XHTML DOM
                    served as application/xhtml+xml
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: XML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: max at ac-mb.info

I'm reporting this as a bug on suggestion by Darin Adler on the dev mailing
list. Here is the related thread where it was first mentioned:
http://lists.webkit.org/pipermail/webkit-dev/2008-January/003082.html

Summary:
When injecting HTML elements into the DOM of a XHTML 1.0 strict document served
as application/xhtml+xml, the web inspector shows unexpected #cdata-section
between injected elements, IF the injection is made by altering the innerHTML
attribute. While reducing a test case to post here, it seems that theses
sections are inserted for linefeed and/or tab sequences. They should be #text.

Injecting into xml doc using innerHTML is not the right way, so I wouldn't
report it if not suggested to.

Worth noting also, when using XMLHttpRequest to get an xhtml chunk, served as
application/xhtml+xml and injected from responseXML using DOM methods, injected
elements are not valid HTML elements if there is no explicit namespace through
xmlns attribute on the container element.

Test case:
XHTML base file (served as application/xhtml+xml):
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
        "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
        <script type="text/javascript" charset="UTF-8"
src="dom_injection.js"></script>
        <title>xhtml DOM injection</title>
</head>

<body onload="inject();">
        <p id='p_static'>This pararagraph is static in xhtml file.
                <a href="#p_static">Link to the anchor of this paragraph.</a>
        </p>
        <div id="target"></div>
</body>
</html>
injected xhtml (no namespace):

<p id="p_inj">This paragraph is ajax injected with no NS.
        <a href="#p_inj">Link to the anchor of this paragraph.</a>

</p>

injected xhtml (namespace):

<p xmlns="http://www.w3.org/1999/xhtml" id="p_inj_NS">This paragraph is ajax
injected with NS.

        <a href="#p_inj_NS">Link to the anchor of this paragraph.</a>

</p>

These two injected files are served either as application/xhtml+xml or
text/html depending of the file extension used to get them.

The javacript test file:

function inject() {
        var target = document.getElementById('target');
        //no #cdata, valid elements, innerHTML injection
        // target.innerHTML += '<p id="p_inj_1">This paragraph is injected
trough innerHTML with no NS. <a href="#p_inj_1">Link to the anchor of this
paragraph.</a></p>';
        //#cdata, valid elements, innerHTML injection
        // target.innerHTML += '\n<p id="p_inj_1">This paragraph is injected
trough innerHTML with no NS. <a href="#p_inj_1">Link to the anchor of this
paragraph.</a></p>';
        //no #cdata, valid elements, innerHTML injection
        // target.innerHTML += '<p xmlns="http://www.w3.org/1999/xhtml"
id="p_inj_NS_1">This paragraph is injected trough innerHTML with NS.\n<a
href="#p_inj_NS_1">Link to the anchor of this paragraph.</a></p>';
        //#cdata, valid elements, innerHTML injection
        // target.innerHTML += '\n<p xmlns="http://www.w3.org/1999/xhtml"
id="p_inj_NS_1">This paragraph is injected trough innerHTML with NS.\n<a
href="#p_inj_NS_1">Link to the anchor of this paragraph.</a></p>';

        var client = new XMLHttpRequest();
        client.onreadystatechange = function () {
                if(this.readyState == 4 && this.status == 200) {
                        if (this.responseXML &&
this.responseXML.documentElement) {
                                window.status = 'importNode'

target.appendChild(document.importNode(this.responseXML.documentElement,
true));
                        }
                        else {
                                window.status = 'innerHTML'
                                target.innerHTML += this.responseText;
                        }
                }
        };

        client.open("GET", "dom_injection_NS.xhtml");  
//application/xhtml+xml, no #cdata, valid elements, DOM methods injection
        // client.open("GET", "dom_injection.xhtml");          
//application/xhtml+xml, no #cdata, invalid elements, DOM methods injection
        // client.open("GET", "dom_injection_NS.html");         //text/html,
#cdata, valid elements, innerHTML injection
        // client.open("GET", "dom_injection.html");            //text/html,
#cdata, valid elements, innerHTML injection
        client.send();

}

Depending of the uncommented line the js file, different case are observed, see
comment.

-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.