[Webkit-unassigned] [Bug 16573] Remove redundant calls to setPrototype in WebCore

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16573





------- Comment #9 from ggaren at apple.com  2008-01-03 09:49 PDT -------
> I used JSValue because in one place (for the JSLocation object) we still use
> jsNull() as the prototype (thought this is a bug) and because the prototype
> ends up being converted to a JSValue when it is stored in _proto.  (Also, in a
> complete cop-out, Geoff told me too :) ).

I agree with Darin: JSObject* is better.

As for JSLocation, we should just give it a real prototype. I think that will
require a little security work, though. So, in the short term, you could just
make JSLocation ignore the passed-in prototype and use jsNull() instead (with a
comment).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.