[Webkit-unassigned] [Bug 16589] WebCore::cookies, WebCore::setCookies and WebCore::cookiesEnabled need access to the WebCore::Document

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 3 00:19:13 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=16589





------- Comment #4 from darin at apple.com  2008-01-03 00:19 PDT -------
(In reply to comment #3)
> Not really disagreeing with Maciej's r+ here, but seeing Document* as a
> setCookie() parameter is rather confusing to me. Perhaps it would be better to
> pass FrameLoader or even FrameLoaderClient?

When it comes to the Frame constellation of objects, we never want to pass
around sub-objects like FrameLoader. FrameLoader is really only the loader
aspect of the frame.

So you'd want to pass either Frame or Document. I think Document is the right
one.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list