[Webkit-unassigned] [Bug 16669] autotools update and fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 1 22:29:05 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

------- Comment #9 from darin at apple.com  2008-01-01 22:29 PDT -------
(In reply to comment #8)
> May I ask, what are the reasons why guards are put in the header files instead
> of in the include sites?

The main reason is that there are more include sites than header files. We
discussed some other reasons on the webkit-dev mailing list.

My main concern is consistency. This patch made DATABASE inconsistent with the
others, and I don't like that.

> > We need to do that work if possible. Putting the VPATH into a different file
> > would be fine.
> Ok. There's already a bit of discussion on this but no definite plan yet on
> when it will happen. 
> Thanks again.
> Reopening the bug for patch submission as per outcome of this discussion. 

It doesn't seem right to reopen this bug for the task of sharing
DerivedSources.make. That task should be tracked with another bug.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list