[Webkit-unassigned] [Bug 13031] onkeydown prevents keyboard shortcuts from working on this page when the input field had focus.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 29 15:45:09 PST 2008


------- Comment #6 from julien.chaffraix at gmail.com  2008-02-29 15:45 PDT -------
(In reply to comment #5)
> (From update of attachment 19411 [edit])
> The code change does not look right to me. I need to understand more of the
> details of why it's necessary to both handle a key and to tell the caller that
> we did not handle it.

The method is called directly from Cocoa and its return value will tell whether
the library has to handle the key (which is the case for shortcut keys).
If we have handled it in WebCore (ret = YES) and we just return that value to
Cocoa, the keyboard shortcut will never be executed (previous behaviour). This
is why we have to pretend that it was not handled in WebCore.
The change is limited to the case where WebCore has handled the event and only
covers event using the Command key to prevent messing with the processing of
other type of event (like shift or control).

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list