[Webkit-unassigned] [Bug 15754] webarchive layout tests fail when WebKit directory path contains symlinks

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15754


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19422|review?                     |
               Flag|                            |
  Attachment #19422|0                           |1
        is obsolete|                            |
  Attachment #19447|                            |review?
               Flag|                            |




------- Comment #5 from ddkilzer at webkit.org  2008-02-29 07:33 PDT -------
Created an attachment (id=19447)
 --> (http://bugs.webkit.org/attachment.cgi?id=19447&action=view)
Patch v2

(In reply to comment #4)
> This patch looks OK to me, but I don't think it will fix the whole problem:
> there are a few webarchive tests that are not located in
> LayoutTests/webarchive. For example, there are svg webarchive tests.

Thanks for catching this.  I fixed this by searching backwards in the URL for
"/LayoutTests/" instead of searching forward for "/LayoutTests/webarchive/". 
Assuming we never create any subdirectories named "LayoutTests" under
"LayoutTests" with webarchive tests in them, this will just work!

I also ran all of the layout tests this time.  The SVG tests did fail with the
previous patch.  They all pass now with this patch, as do
LayoutTests/webarchive.

Sorry it took so long to fix this.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.