[Webkit-unassigned] [Bug 15416] dtoa Falls into infinite loop on ARMEL

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15416


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19444|review+                     |review-
               Flag|                            |




------- Comment #5 from ddkilzer at webkit.org  2008-02-29 03:21 PDT -------
(From update of attachment 19444)
Please set the "review?" flag, not the "review+" flag, to have your patch
reviewed.

>+2008-02-28  weihongzeng  <set EMAIL_ADDRESS environment variable>

Please set your first/last name (not just your account) and your email address
in the ChangeLog file.

>+        Reviewed by NOBODY (OOPS!).
>+
>+        * kjs/dtoa.cpp:
>+        (Bigint::):
>+        (Bigint::freedtoa):

Please refer to this bug in the ChangeLog entry, and describe what you fixed. 
(See other ChangeLog entries for examples.)

>+#ifdef USE_LOCALE
>+	s1 = localeconv()->decimal_point;
>+	if (c == *s1) {
>+		c = '.';
>+		if (*++s1) {
>+			s2 = s;
>+			for(;;) {
>+				if (*++s2 != *s1) {
>+					c = 0;
>+					break;
>+					}
>+				if (!*++s1) {
>+					s = s2;
>+					break;
>+					}
>+				}
>+			}
>+		}
>+#endif

This is incorrect style.  Curly braces appear below their corresponding if
statement.  See this page for more information:

http://webkit.org/coding/coding-style.html

>-						while (*--s == '0') { }
>+						while(*--s == '0');

>-		while (*--s == '0') { }
>+		while(*--s == '0');

Why were these changes made?  I recall that some compilers require the empty
block instead of a semi-colon.  These seem unnecessary.

r- for code style issues and incomplete ChangeLog.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.