[Webkit-unassigned] [Bug 17483] Implement Scrollbars on Windows (Cairo)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17483


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19413|review?                     |review-
               Flag|                            |




------- Comment #14 from aroben at apple.com  2008-02-28 16:14 PDT -------
(From update of attachment 19413)
+#if PLATFORM(CG)
+#define WTF_USE_SAFARI_THEME 1
+#endif

The first line should probably be:

#if PLATFORM(WIN) && !PLATFORM(CG)

since SafariTheme only exists on Windows.

+#if !USE(SAFARI_THEME)
+    mutable HANDLE m_scrollBarTheme;
+#endif

Similarly, this should be:

#if PLATFORM(WIN) && !USE(SAFARI_THEME)

+const unsigned SP_ABS_HOT_MODIFIER = 1;
+const unsigned SP_ABS_PRESSED_MODIFIER = 2;
+const unsigned SP_ABS_DISABLE_MODIFIER = 3;

These should all be marked static.

+    // Cleanup theme stout.uff

Looks like a typo here. I'm not sure this comment is needed though.

+    if (!isEnabled()) {
+        state += SP_ABS_DISABLE_MODIFIER;
+        classicState |= DFCS_INACTIVE;
+    }
+    else if ((m_pressedPart == BackButtonPart && start)
+          || (m_pressedPart == ForwardButtonPart && !start))
+    {
+        state += SP_ABS_PRESSED_MODIFIER;
+        classicState |= DFCS_PUSHED | DFCS_FLAT;
+    }
+    else if (m_client->isActive())
+    {
+       state += SP_ABS_HOT_MODIFIER;
+       classicState |= DFCS_HOT;
+    }

The braces here don't match our coding style.

+    if (!uxthemeLibrary() && !m_scrollBarTheme)
+        m_scrollBarTheme = OpenThemeData(0, L"Scrollbar");

I think you have the wrong condition here. I think you want:

if (uxthemeLibrary() && !m_scrollBarTheme)

The other instances of this seem to have it right.

Maybe this initialization should be put into a helper function, since it's done
over and over?

r- so the above can be fixed, but overall it looks good.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.