[Webkit-unassigned] [Bug 17483] Implement Scrollbars on Windows (Cairo)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17483


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19395|review?                     |review-
               Flag|                            |




------- Comment #11 from aroben at apple.com  2008-02-27 13:51 PDT -------
(From update of attachment 19395)
+        (WebCore::RenderThemeWin::determineState): Extend to recognize
+          scrollbar parts.
+        (WebCore::RenderThemeWin::paintButton): Add new implementation
+          for drawing buttons given a graphic context and bounding box.

I don't see any callers of this new RenderThemeWin method, so I don't think you
should add it or change determineState. Maybe I'm missing something?

It would be good if the changes to make RenderThemeWin use the SOFT_LINK macros
could be broken out into their own patch.

+// Note:  Copied from RenderThemeWin.  There should be some way to better
+// encapsulate/share this stuff.  See all RenderThemeSafari for more such
stuff...
+//
+// After discussion with Adam Roben, we will make the ugly choice of copying
logic
+// from RenderThemeWin until the Theme logic is refactored

I think a shorter comment would suffice, such as:

// FIXME: Refactor this soft-linking code in a way that can be shared with
RenderThemeWin

Can you split up the patch as suggested above and re-upload it? That will make
it much easier to review.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.