[Webkit-unassigned] [Bug 17487] HTMLInput mysteriously fails to work if ICU dat file is missing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 27 07:54:10 PST 2008
http://bugs.webkit.org/show_bug.cgi?id=17487
ap at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #19399|review?(ap at webkit.org) |review+
Flag| |
------- Comment #7 from ap at webkit.org 2008-02-27 07:54 PDT -------
(From update of attachment 19399)
There are still some issues with this patch, but I'm going to say r=me and fix
those when landing.
1. There is no ChangeLog.
2. "+#include <stdio.h>" is no longer needed without fprintf.
3.
+ if (!createdIterator)
+ {
We put opening brace on the same line as "if".
4. Instead of a combination of LOG_ERROR and ASSERT, one can use
ASSERT_WITH_MESSAGE.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list