[Webkit-unassigned] [Bug 16815] Crash with navigator.plugins and navigator.mimeTypes after plugins.refresh

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16815





------- Comment #19 from hausmann at kde.org  2008-02-25 06:12 PDT -------
I have included your suggestions in the latest patch. Thanks for this round of
review!

The readonly attribute change was indeed a bug. A little test that overwrites
window.navigator indicates that it's indeed replaceable like the other window
properties.

The const of the string in window.navigator.appVersion came actually from the
existing code in kjs_navigator.cpp, but I've removed the const now. I'm not
sure about caching the return value of FrameLoaderClient::userAgent due to the
dependency of the URL though. But perhaps I misunderstood your suggestion.

I have also changed Page::refreshPlugins() to continue to operate on the
allPages hashset, but instead of doing any modification it now just collects
all the frames that need a reload in a separate vector. I think that should
protected against potential page/frame creations/deletions as you suggested.

I agree about the confusing namng between PluginData and PluginInfo, but I
think PluginData in the future should simply be merged with PluginDatabase to
clean up the code and resolve this naming problem.

The latest patch still needs an implementation of PluginData on Windows. That
should be pretty straightforward from the existing PluginInfoStore.cpp code.
The mac implementation should require only changes to the xcode project files,
the existing mac/PluginData.mm implementation should work fine.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.