[Webkit-unassigned] [Bug 16815] Crash with navigator.plugins and navigator.mimeTypes after plugins.refresh

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 24 19:51:47 PST 2008


------- Comment #16 from darin at apple.com  2008-02-24 19:51 PDT -------
(From update of attachment 19188)
One thing I'm not happy about is all the classes that have the name XXXInfo and
XXXData. I find them confusing. Like -- what's the difference between
PluginData and PluginInfo? Anything we can do to rationalize these would be a
step in the right direction.

+        PluginData(const Page* page);

We'd normally omit the parameter name for something like this.

+        inline const Vector<PluginInfo*>& plugins() const
+        { return m_plugins; }
+        inline const Vector<MimeClassInfo*>& mimes() const
+        { return m_mimes; }

No reason for the inline keyword on these lines; it has no effect. Also,
normally the function body would be to the right rather than on a separate line

Those are all my comments. I finished reviewing now.

I'd love to help you finish the patch; if I have time soon I might take it and
fix some of the issues I mentioned and do some testing on Mac OS X.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list