[Webkit-unassigned] [Bug 17484] Add Windows (Cairo) support in WebKit.dll

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 24 18:14:11 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #19268|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2008-02-24 18:14 PDT -------
(From update of attachment 19268)
Good general direction. Some comments:

 #include "config.h"
+#include "NotImplemented.h"
 #include "WebDragClient.h"

This is wrong. The first include after "config.h" should be the file's own
header "WebDragClient.h". There should be a blank line after that before the
rest of the includes.

+    notImplemented ();

No space before the parenthesis.

 void WebFrame::dispatchDidReceiveAuthenticationChallenge(DocumentLoader*
loader, unsigned long identifier, const AuthenticationChallenge& challenge)

Not answering the challenge at all will simply make the browser hang. You
should probably do something better than that. Or is there some reason this is


It seems strange to just conditionalize the printing code without adding a call
to notImplemented(). How is this different from the createDragImage case?

 #if !defined(NDEBUG) && defined(USE_DEBUG_SAFARI_THEME)

I think this is backwards. It should be #if PLATFORM(CG), since SafariTheme
relies on CG. In the future we might need to add a conditional about whether
SafariTheme is being included, since someone with CG still might not want
SafariTheme. I definitely don't think that "CAIRO" is a good way to say "no

The purpose of WebKitGraphics is to give a way to draw text if you can't
compile C++ code. There's no reason to have it if the context is a
WebCore::GraphicsContext object. I suggest leaving these functions out entirely
for non-CG platforms.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list