[Webkit-unassigned] [Bug 16947] [GTK] Missing HTTP Auth challenge

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16947





------- Comment #11 from jmalonzo at gmail.com  2008-02-24 00:29 PDT -------
(In reply to comment #10)
> Created an attachment (id=19305)
 --> (http://bugs.webkit.org/attachment.cgi?id=19305&action=view) [edit]
> fail on response fired
> 
> When the response has been fired the application shouldn't be able to fire it
> again for networking matters. So i added a priv->response_fired variable to be
> checked. With this latest change this patch should hopefully be complete.

Hi Lethalman

Some issues:

1. There are still instances where the dialog pops up at least twice (e.g,
trying to log to my router pops up the dialog twice).

2. the table container shouldn't expand when the window resizes. Ditto with the
username/password labels.

3. The OK/Cancel button should be Cancel/Ok for consistency with gtk/gnome
apps.

4. The dialog window title says "Authentication - http://www.google.com" even
though the domain i'm logging to is not google's? Maybe a different bug but
fyi.

5. Also, should we add a title header with more info about the site we're
logging into (like FF for example)?

That's all. Good work so far!

Cheers


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.