[Webkit-unassigned] [Bug 17478] New: testkjs build lacks some defines

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17478

           Summary: testkjs build lacks some defines
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mh+webkit at glandium.org


When building from qmake generated Makefiles, and building the testkjs target
in JavaScriptCore/kjs, a whole bunch of defines are lacking on the gcc command
line, more specifically -DNDEBUG when not building debug builds, which, in
turn, has the nice side effect of provoking a gcc internal compiler error on
s390 because of the 0xbbadbeef pointer, which is another story. The following
patch is enough to bring the defines in, though that might be too much

diff --git a/JavaScriptCore/kjs/testkjs.pro b/JavaScriptCore/kjs/testkjs.pro
index ab3016b..dcffabb 100644
--- a/JavaScriptCore/kjs/testkjs.pro
+++ b/JavaScriptCore/kjs/testkjs.pro
@@ -20,6 +20,7 @@ OBJECTS_DIR = tmp
 OBJECTS_DIR_WTR = $$OBJECTS_DIR/
 win32-*: OBJECTS_DIR_WTR ~= s|/|\|
 include($$PWD/../JavaScriptCore.pri)
+include($$PWD/../../WebKit.pri)

 # Hack!  Fix this.
 SOURCES -= API/JSBase.cpp \


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.