[Webkit-unassigned] [Bug 17336] Update WinCairo WebKit with Font/Text Support

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17336





------- Comment #9 from mitz at webkit.org  2008-02-20 11:44 PDT -------
(From update of attachment 19231)
+    bool fontCreationFailed = (result->cgFont() == 0);

This should just say

+    bool fontCreationFailed = !result->cgFont();

(similarly for the Cairo version).

+#include <wtf/RetainPtr.h>

should come last in FontCustomPlatformDataCairo.cpp.

+    FontCustomPlatformDataCairo(cairo_font_face_t* fontFace)
+    : m_fontFace(fontFace)
+    {}

The initialization should be indented and the braces go on separate lines.

+FontCustomPlatformDataCairo* createFontCustomPlatformData(SharedBuffer*
buffer);

No need to name the argument.

+    static cairo_font_options_t* fontOptions = 0;
+    if (!fontOptions)
+       fontOptions = cairo_font_options_create();
+    cairo_font_options_set_antialias(fontOptions, CAIRO_ANTIALIAS_SUBPIXEL);

No need to initialize the static variable to 0. But more importantly, Darin
pointed out that you probably meant to include
cairo_font_options_set_antialias() in the if block so that you only do it once.

SimpleFontData::platformDestroy() in SimpleFontDataCairoWin.cpp should call
platformCommonDestroy().


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.