[Webkit-unassigned] [Bug 16753] date set methods with no args should result in NaN (Acid3 bug)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16753


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19214|review?                     |review+
               Flag|                            |




------- Comment #18 from darin at apple.com  2008-02-20 09:37 PDT -------
(From update of attachment 19214)
+    if (3 == numArgsToUse && isnan(milli))

I know that in some projects people think that putting the constant on the left
side of an "==" is good style because it helps you avoid the mistake of using
"=" by mistake, but we really don't believe in that, and I think it's strange
to have this once instance of it mixed in with the other code.

The test is great. It's thorough. I'd prefer it if a lot more of the test cases
and results were written out; it's better if the results file shows a lot more
of what's being tested rather than just the conclusions.

If you look at other tests that make heavy use of shouldBe you'll see how that
can work.

+function makeIEHappy (functionNameRoot, value)

We don't put spaces after function names.

+function testDateFunctionWithValueExpectingNaN1(functionNameRoot) {

We put the braces on the next line, not the same line as the function.

r=me as-is, but please consider making improvements as well.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.