[Webkit-unassigned] [Bug 17366] ContextMenu::itemAtIndex() should be static and declared for Windows port only

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 09:30:30 PST 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #19127|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2008-02-20 09:30 PDT -------
(From update of attachment 19127)
I'd prefer to not have the #if in the header. There's no harm in declaring a
function that isn't defined on all platforms, especially if we might want to
define and use it on other platforms in the future. Is there something I'm
overlooking here?

+        static ContextMenuItem* itemAtIndex(unsigned, const

The "const" here, while not new, is not helpful. It doesn't have any effect on
the type of the parameter.

Since there's no significant benefit to this patch, I'm going to set it review-
just because of the minor comments above. If there was a clearer benefit I
might just overlook these and say review+.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list