[Webkit-unassigned] [Bug 17353] XMLTokenizer installs global libxml2 callbacks that can break client applications

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 13:57:37 PST 2008


------- Comment #6 from alp at atoker.com  2008-02-14 13:57 PDT -------
(In reply to comment #4)
> (From update of attachment 19125 [edit])
> r=me, with some reservations.
> Doesn't this still leave us with the problem that other libxml2 clients could
> call xmlRegisterInputCallbacks and clobber our callbacks with their own? Is
> there a "save and restore" approach we could use instead?

Yep, totally. It's not a complete fix. Luckily very few applications seem to
use xmlRegisterInputCallbacks(), so this saves our skin for now.

I tried cooking up a save/restore form of this patch but it still didn't
address the reverse scenario you described. Could you elaborate or maybe give a
proof of concept?

> Should we file a bug asking libxml2 to come up with a way of doing this that's
> not global?

I think dv is aware that the globals are bad. It's possible they've added new a
new way to do this and we haven't seen it yet.

We should file a bug or check up on the existing one (Eric believes a bug has
already been filed).

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list