[Webkit-unassigned] [Bug 17353] XMLTokenizer installs global libxml2 callbacks that can break client applications

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17353


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19125|review?                     |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2008-02-14 13:50 PDT -------
(From update of attachment 19125)
r=me, with some reservations.

Doesn't this still leave us with the problem that other libxml2 clients could
call xmlRegisterInputCallbacks and clobber our callbacks with their own? Is
there a "save and restore" approach we could use instead?

Should we file a bug asking libxml2 to come up with a way of doing this that's
not global?

+    // TODO: We should restore the original global error handler as well.

We use FIXME, not TODO, for these things.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.