[Webkit-unassigned] [Bug 17362] New: discovered dead code in SVG stylesheet title handling of "&"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 10:32:45 PST 2008


http://bugs.webkit.org/show_bug.cgi?id=17362

           Summary: discovered dead code in SVG stylesheet title handling of
                    "&"
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: darin at apple.com


In Document::recalcStyleSelector I discovered some dead code that I removed:

#if ENABLE(SVG)
                // FIXME: What's the point of changing the value of a local
variable
                // (title) that's not looked at afterward? Obviously there's no
test
                // case for this!
                if (!n->isHTMLElement()) {
                    String modifiedTitle = title.domString();
                    title = modifiedTitle.replace('&', "&&");
                }
#endif

We should figure out what this code was trying to do, and then possibly re-add
the code with a test case.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list