[Webkit-unassigned] [Bug 17220] Illogical dependency between PluginView and PluginDatabase

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17220


dobey at wayofthemonkey.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unnecessary dependency      |Illogical dependency between
                   |between PluginView and      |PluginView and
                   |PluginDatabase              |PluginDatabase




------- Comment #8 from dobey at wayofthemonkey.com  2008-02-11 08:16 PDT -------
(In reply to comment #7)
> > The call to PluginDatabase::installedPlugins() in PluginView::create() can't be
> > made without making PluginView aware of PluginDatabase. Doesn't that just move
> > the dependency around?

Ah, unnecessary/unneeded was the wrong term to use. Illogical is more accurate.
Yes, this makes the dependency logical. PluginDatabase should only manage the
PluginPackage instances, and PluginView then requests the appropriate
PluginPackage from PluginDatabase, to use in the PluginView creation.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.