[Webkit-unassigned] [Bug 17307] KURL (and the rest of WebCore) needs unit testing

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17307





------- Comment #2 from eric at webkit.org  2008-02-11 01:40 PDT -------
Btw, for any of those of you curious as to what the actual output of this is:
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)
.
FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)
.
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)
.
FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)
.
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)
.
FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)
.
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)
.
FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)
.
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)

FAIL: resolve_cases[i].expected == output.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:188)

FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)

FAIL: resolve_cases[i].expected == outputw.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:195)

FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)
.
FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)
.
FAIL: resolve_cases[i].expected_valid == output.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:187)

FAIL: resolve_cases[i].expected == output.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:188)

FAIL: resolve_cases[i].expected_valid == outputw.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:194)

FAIL: resolve_cases[i].expected == outputw.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:195)
....
FAIL: replace_cases[i].expected == url.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:252)

FAIL: replace_cases[i].expected == url.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:252)
..
FAIL: ip_tests[i].expected_ip == url.HostIsIPAddress()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:290)
....
FAIL: url.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:79)
..........
FAIL: "q=a" == url.query()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:93)
.
FAIL: url_1.DomainIs(google_domain)
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:298)
.
FAIL: url_3.DomainIs(google_domain)
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:304)
..
FAIL: url_6.DomainIs(".com.")
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:313)
......
FAIL: cases[i].expected == path_request
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:271)
.
FAIL: cases[i].expected == path_request
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:271)
.
FAIL: "http://google.com:foo/" == url.possibly_invalid_spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:150)
...
FAIL: "google.com" == url.host()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:155)

FAIL: "foo" == url.port()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:156)
.
FAIL: "/" == url.path()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:158)
...
FAIL: cases[i].expected == empty_path.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:212)

FAIL: cases[i].expected == empty_path.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:212)
......
FAIL: "" == url.port()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:106)
....
FAIL: "http://www.google.com/asdf" == url_1.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:332)

FAIL: "http://www.google.com/foo" == url_2.spec()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:336)

FAIL: url2.is_valid()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:117)
........
FAIL: "q=a" == url2.query()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:127)
.......
FAIL: "" == invalid2.port()
(/Stuff/Projects/WebKit/WebCore/unit-tests/platform/KURL_tests.cpp:139)
....


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.