[Webkit-unassigned] [Bug 17299] Patch providing fully-buildable Cairo-backed Win32 WebCore

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17299





------- Comment #3 from darin at apple.com  2008-02-10 17:59 PDT -------
(From update of attachment 19051)
Patch looks good. Some small issues:

 #include "config.h"
+#include "PlatformString.h"
+#include "CSSValueKeywords.h"
 #include "RenderThemeWin.h"

New includes should go in a separate group. See the
<http://webkit.org/coding/coding-style.html> section called "#include
statements".

+        cachedDesc->firstFamily().setFamily("Lucida Grande");

Are you sure that's the right choice? I don't think that font is included by
default on Windows.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.